Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on ProjectivePoint: ToEncodedPoint #95

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

daxpedda
Copy link
Contributor

This reverts the unfortunate changes that had to be made in #91.
It was fixed in RustCrypto/elliptic-curves#722.

This will actually require downstream users to update their primeorder dependency to v0.12.1, personally I don't think it is a problem, but the gain is also very minor.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 31, 2023
@daxpedda
Copy link
Contributor Author

CI fails because of Clippy, see #96.

Copy link
Contributor

@kevinlewi kevinlewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daxpedda
Copy link
Contributor Author

Rebased on #96.

@kevinlewi kevinlewi merged commit 0409db6 into facebook:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants