Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#58 review #59

Merged
merged 1 commit into from
Feb 13, 2022
Merged

#58 review #59

merged 1 commit into from
Feb 13, 2022

Conversation

daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Feb 12, 2022 •
edited
Loading

This builds on top of #58.

  • Remove hex from dependencies.
  • Revert std as default feature.
  • Correct error documentation.
  • Revert old change of passing Mode into hash_to_curve and hash_to_scalar.
  • Fix documentation tests.
  • Fix documentation links.
  • Introduce no alloc version of batch_evaluate for POPRF and VOPRF.
  • Fix wrong errors.
  • Fix returning Result instead of panicking when using derive_key_pair.
  • Change public functions to take iterators instead of slices when batching.
  • Remove some unnecessarily returned Results.
  • Improve derive_keypair.
  • Remove i2osp_1.
  • Some general code improvements.

Sadly I was unable to make a complete no alloc solution for POPRF despite my hopes mentioned on Slack.
I apologize for this single mega-commit!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 12, 2022
@daxpedda daxpedda changed the base branch from main to version_09 February 12, 2022 04:35
@daxpedda daxpedda mentioned this pull request Feb 12, 2022
Merged
kevinlewi
kevinlewi approved these changes Feb 13, 2022
View reviewed changes
Copy link
Contributor

@kevinlewi kevinlewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you!

@kevinlewi kevinlewi merged commit b949012 into facebook:version_09 Feb 13, 2022
kevinlewi added a commit that referenced this pull request Feb 13, 2022
@kevinlewi @daxpedda
Merging Version 09 changes into main (#60)
f8e0600 
* Syncing new test vectors and base mode

* Working set of test vectors for VOPRF mode

* Adding POPRF

* POPRF test vectors in sync

* Address review (#59)

Co-authored-by: daxpedda <daxpedda@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinlewi kevinlewi kevinlewi approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daxpedda @kevinlewi @facebook-github-bot