General improvements #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
daxpedda
commented
Jan 24, 2022
Comment on lines
+30
to
+31
| /// The protocol has failed and can't be completed. | ||
| Protocol, |
There was a problem hiding this comment.
I couldn't come up with a better name or description that actually explains the error to a user. I think InverseError doesn't make any sense to a user.
This was referenced Jan 24, 2022
daxpedda
force-pushed
the
improvements-6
branch
from
d0ccc11
to
95fd303
Compare
Merged
kevinlewi
approved these changes
Jan 28, 2022
|
Oh oops, I probably should have re-run the CI before merging this, seems like the main branch now is failing CI. @daxpedda any ideas here? |
|
Yes ... this is interesting and something I wasn't aware of, depending on pre-releases can automatically update. I thought that pre-releases can not update as they are considered unstable. This is addressed by #54, I'm gonna pin pre-release dependencies there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #55.
Ristretto255.NonVerifiableServerEvaluateResultas it was holding only one type.warn(missing_debug_implementations)and implementDebugon all public types.copymethods now that we are compiling withoutalloc.PreparedEvaluationElementandPreparedTscalar.Iterators in the public API.Evaluateaccording to the spec.GenericArrays to slices.new_with_keywould panic if bytes don't have the right length.serdede/serialization to use the checked variants inGroup.