General Improvements #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
daxpedda
force-pushed
the
improvements-5
branch
from
6609799
to
54dfc90
Compare
daxpedda
force-pushed
the
improvements-5
branch
from
9a21e8a
to
cc65ed5
Compare
daxpedda
force-pushed
the
improvements-5
branch
from
cc65ed5
to
b6924d5
Compare
daxpedda
commented
Dec 25, 2021
Comment on lines
+27
to
+28
| output[L::USIZE.saturating_sub(SIZEOF_USIZE)..] | ||
| .copy_from_slice(&input.to_be_bytes()[SIZEOF_USIZE.saturating_sub(L::USIZE)..]); |
There was a problem hiding this comment.
This is correct as far as I can tell, but I'm pointing it out here to be extra-careful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resultshorthand:Result<T, InternalError.InternalErrortoError, I believe this was an artifact when we still had multiple error types.Group,Result,Error,VerifiableClientBatchFinalizeResultandVerifiableServerBatchEvaluateResult.groupanderrormodules private, because of re-exports.Proof, this was kinda a bug because downstream users couldn't use that type, strange that Rust didn't complain.deserializeto theserializemodule, the only place it was used.serializeandserialize_ownedto methods ofSerialized, which was renamed toSerialize.