Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Rustfmt and Taplo #38

Merged
merged 2 commits into from
Dec 23, 2021
Merged

Configure Rustfmt and Taplo #38

merged 2 commits into from
Dec 23, 2021

Conversation

daxpedda
Copy link
Contributor

Rustfmt by default does the right thing, though there are some improvements that can be made by using unstable features. This does require nightly, but adds a couple of nice features that don't have to be done manually anymore:

  • Check the license header.
  • Format comments.
  • Format code in doc comments
  • Properly sort and enforce import granularity.

I can also add Taplo to format TOML files if you would like, no real effort required.

Based on #34 so I don't have to re-base.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 10, 2021
@kevinlewi
Copy link
Contributor

Sure, let's add Taplo as well, thanks!

@daxpedda
Copy link
Contributor Author

Ci keeps getting automatically cancelled sometimes, everything looks great though.

@daxpedda daxpedda changed the title Configure Rustfmt Configure Rustfmt and Taplo Dec 10, 2021
@daxpedda daxpedda force-pushed the rustfmt branch 2 times, most recently from cac2494 to ac93bb0 Compare December 11, 2021 14:13
@daxpedda
Copy link
Contributor Author

Re-based.

@kevinlewi kevinlewi merged commit 140f9e0 into facebook:main Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants