Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ristretto255 feature #35

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Conversation

daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Dec 9, 2021

This is an idea I wanted to propose. It introduces a feature called ristretto255 which is enabled automatically by every ristertto255_* backend feature. It allows us to simplify feature selection in the code, but also improves the documentation:
grafik
Instead of:
grafik

I'm hoping that at some point in the future this all goes away and we can simply depend on traits.

This builds on top of #34.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 9, 2021
@daxpedda daxpedda force-pushed the ristretto255-feature branch 4 times, most recently from b10447e to 34cb3ef Compare December 10, 2021 01:51
Copy link
Contributor

@kevinlewi kevinlewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@daxpedda
Copy link
Contributor Author

Re-based.

@daxpedda
Copy link
Contributor Author

Re-based.

@kevinlewi kevinlewi merged commit 6669a0c into facebook:main Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants