Update to draft 19 #101
Merged
Update to draft 19 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
daxpedda
force-pushed
the
draft-19
branch
2 times, most recently
from
64b746e
to
738d0e2
Compare
This was referenced Feb 1, 2023
Merged
|
There also was a change in the test in the test vectors between draft-16 and draft-17: |
|
The tests didn't change, just the output, because of the change to the context string. |
|
This is now ready to be merged, but if possible I would like to get a new pre-release for |
|
Now builds on top of #102. |
|
This is ready to be merged now! |
kevinlewi
approved these changes
Feb 8, 2023
Comment on lines
+500
to
+503
| pub(crate) struct Dst<L: ArrayLength<u8>> { | ||
| dst_1: GenericArray<u8, L>, | ||
| dst_2: &'static str, | ||
| } |
kevinlewi
approved these changes
Feb 8, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates VOPRF to be in sync with draft 19.
There are no changes compared to draft 11, which is what we were on until now, except:
OPRFV1-.The change to the Ciphersuite ID requires us to update to
elliptic-curvev0.13.0-pre.5, which I've done here. This also requires an upgrade to Rust 1.61.This small change posed some difficulties because of the non-fixed-size nature of this ID. To avoid allocation I had to change the API in
elliptic-curve(RustCrypto/traits#1238) and introduce a new internal helper type:Dst.This also changed some of hash traits we used, namely instead of
Digestwe no requireDefault + FixedOutput + HashMarker, which should pose no downstream issues.This build on top of:
elliptic-curve: elliptic-curve: Allow multipledsts in the hash2curve API RustCrypto/traits#1238p256(for testing only): AddFieldBytesEncodingtrait impls RustCrypto/elliptic-curves#732We should probably wait for the release ofelliptic-curvev0.13.0-pre.4 before merging this.Was released!
Builds on top of #102.