Correct java docs of RocksDB options #6123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct javadocs of several RocksDB option classes to not mislead RocksJava users.
|
LGTM. Thank you :-) |
|
@adamretter Could you help merge this? |
|
@Myasuka I don't have merge rights. @pdillinger could you merge this please? |
pdillinger
approved these changes
Dec 13, 2019
There was a problem hiding this comment.
@pdillinger is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@pdillinger merged this pull request in 4b74035. |
Myasuka
added a commit
to Myasuka/flink
that referenced
this pull request
Dec 13, 2019
…entation This refer to facebook/rocksdb#6123 which correctis RocksDB javadoc
azagrebin
pushed a commit
to apache/flink
that referenced
this pull request
Dec 20, 2019
…entation This refer to facebook/rocksdb#6123 which correctis RocksDB javadoc
azagrebin
pushed a commit
to apache/flink
that referenced
this pull request
Dec 20, 2019
…entation This refer to facebook/rocksdb#6123 which correctis RocksDB javadoc
azagrebin
pushed a commit
to apache/flink
that referenced
this pull request
Dec 20, 2019
…entation This refer to facebook/rocksdb#6123 which correctis RocksDB javadoc
azagrebin
pushed a commit
to apache/flink
that referenced
this pull request
Dec 20, 2019
…entation This refer to facebook/rocksdb#6123 which correctis RocksDB javadoc
wolfkdy
pushed a commit
to wolfkdy/rocksdb
that referenced
this pull request
Dec 22, 2019
Summary: Correct javadocs of several RocksDB option classes to not mislead RocksJava users. Pull Request resolved: facebook#6123 Differential Revision: D18989044 Pulled By: pdillinger fbshipit-source-id: a5ac6a415e5311084b10d973d354e6925788f01e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct javadocs of several RocksDB option classes to not mislead RocksJava users.