bugfix: MemTableList::RemoveOldMemTables invalid iterator after remov… #6013
Conversation
|
Hi CAIQT! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Thanks @CAIQT for the fix. I have a minor comment.
Could you please update the PR description to include more context? Could you also run make format to fix potential format issue (if any)?
There was a problem hiding this comment.
@riversand963 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…st::RemoveOldMemTables invalid iterator after removement
|
@CAIQT has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@riversand963 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@CAIQT has updated the pull request. Re-import the pull request |
|
@CAIQT has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@riversand963 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@riversand963 merged this pull request in f29e6b3. |
|
@riversand963 merged this pull request in f29e6b3. |
facebook#6013) Summary: Fix issue facebook#6012. I found that it may be caused by the following codes in function _RemoveOldMemTables()_ in **db/memtable_list.cc** : ``` for (auto it = memlist.rbegin(); it != memlist.rend(); ++it) { MemTable* mem = *it; if (mem->GetNextLogNumber() > log_number) { break; } current_->Remove(mem, to_delete); ``` The iterator **it** turns invalid after `current_->Remove(mem, to_delete);` Pull Request resolved: facebook#6013 Test Plan: ``` make check ``` Differential Revision: D18401107 Pulled By: riversand963 fbshipit-source-id: bf0da3b868ed70f7aff24cf7b3e2049c0c5c7a4e
Fix issue #6012.
I found that it may be caused by the following codes in function RemoveOldMemTables() in db/memtable_list.cc :
The iterator it turns invalid after
current_->Remove(mem, to_delete);Test plan: