WriteUnPrepared: Fix bug in savepoints #5703
Conversation
There was a problem hiding this comment.
@lth has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
| @@ -729,7 +736,6 @@ Status WriteUnpreparedTxn::RollbackToSavePointInternal() { | |||
| assert(flushed_save_points_->size() > 0); | |||
| WriteUnpreparedTxn::SavePoint& top = flushed_save_points_->back(); | |||
|
|
|||
| assert(top.unprep_seqs_.size() > 0); | |||
There was a problem hiding this comment.
Why is this assert removed?
There was a problem hiding this comment.
This is removed because now we may skip flushing a write batch, if that write batch is empty, but we still want to save the savepoint.
If we set savepoint right after begin transaction, then when we flush the write batch, the first savepoint would not have any unprep_seqs because no flush was done.
|
@lth has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@lth has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@lth has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@lth has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Fix a bug in write unprepared savepoints. When flushing the write batch according to savepoint boundaries, we were forgetting to flush the last write batch after the last savepoint, meaning that some data was not written to DB. Also, add a small optimization where we avoid flushing empty batches. Pull Request resolved: facebook#5703 Differential Revision: D16811996 Pulled By: lth fbshipit-source-id: 600c7e0e520ad7a8fad32d77e11d932453e68e3f
Fix a bug in write unprepared savepoints. When flushing the write batch according to savepoint boundaries, we were forgetting to flush the last write batch after the last savepoint, meaning that some data was not written to DB.
Also, add a small optimization where we avoid flushing empty batches.