-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support manual flush in stress/crash tests #4368
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
tools/db_stress.cc
Outdated
FlushOptions flush_opts; | ||
Status status = db_->Flush(flush_opts, column_family); | ||
if (!status.ok()) { | ||
printf("Unable to perform Flush(): %s\n", status.ToString().c_str()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use fprintf
?
address comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ajkr is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Flush()
periodically according to--flush_one_in
flag.Test Plan: ran
python tools/db_crashtest.py --simple blackbox