Fix heap use after free ASAN/Valgrind #1535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IslamAbdelRahman
assigned IslamAbdelRahman, siying and yhchiang and unassigned IslamAbdelRahman
|
@IslamAbdelRahman has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
siying
approved these changes
Nov 17, 2016
| @@ -134,7 +134,7 @@ bool RocksLuaCompactionFilter::Filter(int level, const Slice& key, | |||
| } | |||
|
|
|||
| const char* RocksLuaCompactionFilter::Name() const { | |||
| std::string name = ""; | |||
| name_ = ""; | |||
There was a problem hiding this comment.
I'm approving it to unblock the build. But I think we shouldn't recalculate the name if we already have it in name_.
There was a problem hiding this comment.
Agreed. Thanks for spotting and fixing the issue.
There was a problem hiding this comment.
Ok, let me update it before landing
|
@IslamAbdelRahman updated the pull request - view changes - changes since last import |
|
Update to use cached name_ |
siying
approved these changes
Nov 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dont use c_str() of temp std::string in RocksLuaCompactionFilter::Name()