BackupableDBTest.CorruptionsTest failed #66
Comments
|
The unit test code seems not self contained. Failure due to backupdir_+/meta/2 does not exist when assertion checked by unit test code. |
|
Did you run the test on the latest checkout? |
|
Yes. It was check out two days ago. - Jerry From: Lei Jin [mailto:notifications@github.com] Did you run the test on the latest checkout? — |
|
Can you rebase and try it again. There was an issue in the test that did not cover a case well. But that got fixed on Tuesday. So I guess you checked out the code before. |
|
Sure. I will rebase and try it again. Sent from my iPhone On Jan 30, 2014, at 10:07 AM, "Lei Jin" <notifications@github.commailto:notifications@github.com> wrote: Can you rebase and try it again. There was an issue in the test that did not cover a case well. But that got fixed on Tuesday. So I guess you checked out the code before. — |
|
I will rebase and try it again. From: Lei Jin [mailto:notifications@github.com] Can you rebase and try it again. There was an issue in the test that did not cover a case well. But that got fixed on Tuesday. So I guess you checked out the code before. — |
|
After rebased, it works now. Issue closed. |
* tools: use provided options instead of the default (facebook#4839) Summary: The current implementation hardcode the default options in different places, which makes it impossible to support other environments (like encrypted environment). Pull Request resolved: facebook#4839 Differential Revision: D13573578 Pulled By: sagar0 fbshipit-source-id: 76b58b4b758902798d10ff2f52d9f39abff015e7 * Fix skip WAL for whole write_group when leader's callback fail (facebook#4838) Summary: The original implementation has two problems: 1. https://github.com/facebook/rocksdb/blob/f0dda35d7de1fd56e0b7c96376ca8aff2a6364fd/db/db_impl_write.cc#L478 https://github.com/facebook/rocksdb/blob/f0dda35d7de1fd56e0b7c96376ca8aff2a6364fd/db/write_thread.h#L231 If the callback status of leader of the write_group fails, then the whole write_group will not write to WAL, this may cause data loss. 2. https://github.com/facebook/rocksdb/blob/f0dda35d7de1fd56e0b7c96376ca8aff2a6364fd/db/write_thread.h#L130 The annotation says that Writer.status is the status of memtable inserter, but the original implementation use it for another case which is not consistent with the original design. Looks like we can still reuse Writer.status, but we should modify the annotation, so Writer.status is not only the status of memtable inserter. Pull Request resolved: facebook#4838 Differential Revision: D13574070 Pulled By: yiwu-arbug fbshipit-source-id: a2a2aefcfd329c4c6a91652bf090aaf1ce119c4b
facebook#5553) Fixes facebook#66 This is a cherry-pick from Facebook's master. Summary: - Provide assignment operator in CompactionStats - Provide a copy constructor for FileDescriptor - Remove std::move from "return std::move(t)" in BoundedQueue Pull Request resolved: facebook#5553 Differential Revision: D16230170 fbshipit-source-id: fd7c6e52390b2db1be24141e25649cf62424d078
==== Test BackupableDBTest.CorruptionsTest
Created bg thread 0x2b414669c700
utilities/backupable/backupable_db_test.cc:588: Assertion failure file_manager_->FileExists(backupdir_ + "/meta/2")
#0 ./backupable_db_test() [0x41b38b] ~basic_string /usr/include/c++/4.8/bits/basic_string.h:539
#1 ./backupable_db_test() [0x41bff4] ~_Test_CorruptionsTest /home/jfan/dev/offlinedb/rocksdb/utilities/backupable/backupable_db_test.cc:522
#2 ./backupable_db_test() [0x4be6eb] rocksdb::test::RunAllTests() /home/jfan/dev/offlinedb/rocksdb/util/testharness.cc:46
#3 /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5) [0x2b41460f6ed5] ?? ??:0
#4 ./backupable_db_test() [0x4132fe] _start ??:?
make: *** [check] Error 1
on Ubuntu 13.10 after resolved dependencies following instructions of INSTALL.md. Built successfully but unit test failed in above test.
The text was updated successfully, but these errors were encountered: