Stabilize LiveResolverStore as the new implementation of RelayModernStore #4806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@captbaritone merged this pull request in 1467b6c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the last several years we've maintained RelayModernStore and LiveResolverStore in parallel. This was because the the Relay store needed to gain some additional features in order to support Resolvers and Live Resolvers.
The upshot was the using Relay Resolvers required adopting a special store. We've now been using this store on ~all surfaces internally for quite a while and have not seen any issues. I believe it should now be safe to unify the implementations and bring the features of the LiveResolver store to the default store: RelayModernStore.
This should allow us to make Relay Resolvers and Live Resolvers as stable (not requiring any additional configuration or feature flags) in an upcoming release. I'll followup with another PR to remove the last feature flag.