Skip check for source control integration if noSourceControl: true is set in config. #4767
Conversation
|
@tyao1 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
For making it a config, you could add the config here: |
Markionium
changed the title
|
@tyao1 Updated the PR, tested to make sure it works for both scenarios (Single and Multi project config files). I'm not sure if there any tests for this source control integration that I could have updated/added to? [Edit]: I realized we can keep everything in |
|
@tyao1 should be good to go now! |
This PR adds the option to pass `--noSourceControl` which will skip the `git status` and `sl --version` commands when creating the configuration. Those checks are run to help the compiler add/remove files from source control for you. However in cases where the generated files are not checked into source control this isn't helpful, especially when `git status` is "slow". I noticed a significant decrease in performance between 16 and 17 when `git status` was introduced.
Markionium
force-pushed
the
no-source-control
branch
from
6770426 to
f30259e
Compare
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Looks good! |
|
@captbaritone merged this pull request in 4d140d2. |
This PR adds the option to add
noSourceControl: trueto the relay config which will skip thegit statusandsl --versioncommands when creating the configuration.Those checks are run to help the compiler add/remove files from source control for you. However in cases where the generated files are not checked into source control this isn't helpful, especially when
git statusis "slow".I noticed a significant decrease in performance between 16 and 17 when
git statuswas introduced.Another issue we have internally in Microsoft is that we use BuildXL in some of our repos, which distributes building of our packages. However it will not allow reads to undeclared dependencies, a
git statuscheck will break that "rule" as it read across the whole repo.In the repo I work on we do not check in our artefacts and thus do not need source control integration.