Feature: Nested input type field completions #4148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g_fragment_spread`
|
@alunyov has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Thank you @beaumontjonathan for this contribution, this is great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for nested input type field completions
Previously there were no completions within input type objects. This MR adds deeply nested support for input field suggestions.
This works for both constant & non-constant values & supports input objects within lists. It supports not showing input fields which have already been provided.
Examples
Note: Please ignore the commit history, I branched off another branch which has already been merged