Fix LSP completion icon for fields #4131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rbalicki2 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Thanks!! This makes a lot more sense, thank you for fixing it |
|
No worries! I'm just trying out the VSCode plugin for the first time & there are a few other things I'd like to fix up if I get the time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorrect LSP completion icons for scalar fields
I noticed that the VSCode extension seemed to use weird icons for completion suggestions of value and text for items which are actually _field_s based on the VSCode IntelliSense docs. E.g.,
Stringtypes were showing up just as plaintext type. All non-struct/union/interface/object types should just be considered a field.Before
After