Compiler: fix validation of required fields with default values #2903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@tyao1 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
josephsavona
requested changes
Oct 24, 2019
packages/relay-compiler/transforms/ValidateRequiredArgumentsTransform.js
Outdated
Show resolved
Hide resolved
Previously, Relay Compiler threw an error incorrectly on fields with required values AND default values defined in the schema. This change takes the default values into account so that you don't have to specify them in the operation/fragment definition. Closes: #2894
|
Hi @tyao1 - would you please consider importing it again? I fixed the code review comments. |
There was a problem hiding this comment.
@tyao1 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@mrtnzlml thank you for fixing this! I'll try to release 7.0.1 soon |
jstejada
pushed a commit
that referenced
this pull request
Dec 19, 2019
Summary: Previously, Relay Compiler threw an error incorrectly on fields with required values AND default values defined in the schema. This change takes the default values into account so that you don't have to specify them in the operation/fragment definition. Closes: #2894 Pull Request resolved: #2903 Reviewed By: josephsavona Differential Revision: D18109039 Pulled By: tyao1 fbshipit-source-id: c801d2eb2c3e13cc6d879ce44b6dd158f2b25aa3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Relay Compiler threw an error incorrectly on fields with required values AND default values defined in the schema. This change takes the default values into account so that you don't have to specify them in the operation/fragment definition.
Closes: #2894