[Added]: crossenv for jest script #2732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Present script will throw a system error in windows displaying ``` 'NODE_ENV' is not recognized as an internal or external command, operable program or batch file. ``` fix To fix this we can have seperate jest script based on platform The new script `"jest:win32": "SET NODE_ENV=test && jest \"$@\"", `
|
can you use crossenv instead https://github.com/kentcdodds/cross-env? |
|
Yeah..it can be done, then have to add it as a dependency here. Is it fine then ? |
|
let's go with crossenv |
|
okay |
Added cross-env package as dependency to run the jest script in cross other OS without crash .
|
cc @sibelius |
sibelius
approved these changes
May 13, 2019
anikethsaha
changed the title
|
@jstejada PTAL // |
There was a problem hiding this comment.
@kassens is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thanks! |
|
@kassens Should I rebase ? |
|
No need, it merged cleanly :) |
|
Great 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The present script
Present Error
Will throw a system error in windows displaying
fix
To fix this we can have seperate jest script based on platform
The new script
The above script will work fine with windows and OSX. And the
jestforlinux