Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo: Missing period on Relay.RootContainer #1247

Closed
wants to merge 2 commits into from

Conversation

washt
Copy link
Contributor

@washt washt commented Jun 28, 2016

RelayRootContainer should be Relay.RootContainer

@ghost
Copy link

ghost commented Jun 28, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@josephsavona
Copy link
Contributor

josephsavona commented Jun 28, 2016

This should really be <Relay.Renderer ... /> (docs) - we haven't updated all the docs to reference it yet. Would you care to update this usage?

@washt
Copy link
Contributor Author

washt commented Jun 28, 2016

Sure!

@steveluscher
Copy link
Contributor

Nice! Can I impose on your generosity even further, and ask that you replace the Root Container guide with a Relay Renderer guide in a follow up PR, now that you're on a roll?

@facebook-github-bot shipit

@ghost
Copy link

ghost commented Jun 29, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review.

@ghost ghost closed this in 854e1fe Jun 29, 2016
@washt
Copy link
Contributor Author

washt commented Jun 30, 2016

Of course, no problem 👍

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants