DissalowIDAsAlias on nested fields

Reviewed By: kassens

Differential Revision: D18816334

fbshipit-source-id: e08ae96ae53bc5ea4edceba09303bd07c4725e3d

packages/relay-compiler/codegen/__tests__/__snapshots__/compileRelayArtifacts-test.js.snap

@@ -9473,6 +9473,41 @@ Fragment {
 }
 `;
 
+exports[`compileRelayArtifacts matches expected output: id-as-alias.invalid.graphql 1`] = `
+~~~~~~~~~~ INPUT ~~~~~~~~~~
+# expected-to-throw
+fragment User_fragment on User {
+  id: name
+}
+
+fragment ProfilePicture on User {
+  profilePicture(size: $size) {
+    id: uri
+  }
+}
+
+~~~~~~~~~~ OUTPUT ~~~~~~~~~~
+THROWN EXCEPTION:
+
+Encountered 2 errors:
+- Relay does not allow aliasing fields to \`id\`. This name is reserved for the globally unique \`id\` field on \`Node\`.
+  
+  Source: GraphQL request (3:3)
+  2: fragment User_fragment on User {
+  3:   id: name
+       ^
+  4: }
+  
+- Relay does not allow aliasing fields to \`id\`. This name is reserved for the globally unique \`id\` field on \`Node\`.
+  
+  Source: GraphQL request (8:5)
+  7:   profilePicture(size: $size) {
+  8:     id: uri
+         ^
+  9:   }
+  
+`;
+
 exports[`compileRelayArtifacts matches expected output: inline-and-mask-are-incompatible.invalid.graphql 1`] = `
 ~~~~~~~~~~ INPUT ~~~~~~~~~~
 # expected-to-throw
@@ -9896,26 +9931,6 @@ Source: GraphQL request (17:24)
 
 `;
 
-exports[`compileRelayArtifacts matches expected output: is-as-alias.invalid.graphql 1`] = `
-~~~~~~~~~~ INPUT ~~~~~~~~~~
-# expected-to-throw
-fragment User_fragment on User {
-  id: name
-}
-
-~~~~~~~~~~ OUTPUT ~~~~~~~~~~
-THROWN EXCEPTION:
-
-Relay does not allow aliasing fields to \`id\`. This name is reserved for the globally unique \`id\` field on \`Node\`.
-
-Source: GraphQL request (3:3)
-2: fragment User_fragment on User {
-3:   id: name
-     ^
-4: }
-
-`;
-
 exports[`compileRelayArtifacts matches expected output: kitchen-sink.graphql 1`] = `
 ~~~~~~~~~~ INPUT ~~~~~~~~~~
 query NodeQuery($id: ID!, $cond: Boolean!, $PictureSize: [Int]!) {

packages/relay-compiler/codegen/__tests__/fixtures/compileRelayArtifacts/id-as-alias.invalid.graphql

@@ -0,0 +1,10 @@
+# expected-to-throw
+fragment User_fragment on User {
+  id: name
+}
+
+fragment ProfilePicture on User {
+  profilePicture(size: $size) {
+    id: uri
+  }
+}

packages/relay-compiler/transforms/DisallowIdAsAlias.js

@@ -28,7 +28,7 @@ function visitField<T: ScalarField | LinkedField>(field: T): T {
       [field.loc],
     );
   }
-  return field;
+  return this.traverse(field);
 }
 
 /**