Sort fragment arguments, updated artifacts

Reviewed By: tyao1 Differential Revision: D21892665 fbshipit-source-id: f594acb412f234e4ec8e4f6dc1fbe231b729c3fa
facebook · Jun 5, 2020 · b065ae2 · b065ae2
1 parent 9e29299
commit b065ae2
Show file tree

Hide file tree

Showing 2 changed files with 117 additions and 108 deletions.
diff --git a/packages/relay-compiler/codegen/ReaderCodeGenerator.js b/packages/relay-compiler/codegen/ReaderCodeGenerator.js
@@ -46,7 +46,6 @@ import type {
   ReaderInlineDataFragmentSpread,
   ReaderLinkedField,
   ReaderModuleImport,
-  ReaderRefetchMetadata,
   ReaderScalarField,
   ReaderSelection,
 } from 'relay-runtime';
@@ -158,25 +157,35 @@ function generateArgumentDefinitions(
   schema: Schema,
   nodes: $ReadOnlyArray<ArgumentDefinition>,
 ): $ReadOnlyArray<ReaderArgumentDefinition> {
-  return nodes.map(node => {
-    switch (node.kind) {
-      case 'LocalArgumentDefinition':
-        return {
-          defaultValue: node.defaultValue,
-          kind: 'LocalArgument',
-          name: node.name,
-          type: schema.getTypeString(node.type),
-        };
-      case 'RootArgumentDefinition':
-        return {
-          kind: 'RootArgument',
-          name: node.name,
-          type: node.type ? schema.getTypeString(node.type) : null,
-        };
-      default:
-        throw new Error();
-    }
-  });
+  return nodes
+    .map(node => {
+      switch (node.kind) {
+        case 'LocalArgumentDefinition':
+          return {
+            defaultValue: node.defaultValue,
+            kind: 'LocalArgument',
+            name: node.name,
+            type: schema.getTypeString(node.type),
+          };
+        case 'RootArgumentDefinition':
+          return {
+            kind: 'RootArgument',
+            name: node.name,
+            type: node.type ? schema.getTypeString(node.type) : null,
+          };
+        default:
+          throw new Error();
+      }
+    })
+    .sort((nodeA, nodeB) => {
+      if (nodeA.name > nodeB.name) {
+        return 1;
+      }
+      if (nodeA.name < nodeB.name) {
+        return -1;
+      }
+      return 0;
+    });
 }
 
 function generateClientExtension(