Add 2 JS snapshot tests to SkipRedundantNodesTransform

Reviewed By: jstejada Differential Revision: D20285547 fbshipit-source-id: 8d1e52432c9407691812376aa781455bc4a92741
facebook · Mar 6, 2020 · 9883c81 · 9883c81
1 parent 24180d7
commit 9883c81
Show file tree

Hide file tree

Showing 3 changed files with 117 additions and 0 deletions.
diff --git a/...elay-compiler/transforms/__tests__/__snapshots__/SkipRedundantNodesTransform-test.js.snap b/...elay-compiler/transforms/__tests__/__snapshots__/SkipRedundantNodesTransform-test.js.snap
@@ -68,6 +68,43 @@ query DontSkipNestedFieldsAcrossFragments {
 
 `;
 
+exports[`SkipRedundantNodesTransform matches expected output: dont-skip-with-inline-on-diffent-types.graphql 1`] = `
+~~~~~~~~~~ INPUT ~~~~~~~~~~
+query DontSkipWithInlineFragmentOnDifferentTypes {
+  viewer {
+    actor {
+      ... on Actor {
+        id
+      }
+      ... on User {
+        id # we currently don't skip this
+        hometown {
+          name
+        }
+      }
+    }
+  }
+}
+
+~~~~~~~~~~ OUTPUT ~~~~~~~~~~
+query DontSkipWithInlineFragmentOnDifferentTypes {
+  viewer {
+    actor {
+      ... on Actor {
+        id
+      }
+      ... on User {
+        id
+        hometown {
+          name
+        }
+      }
+    }
+  }
+}
+
+`;
+
 exports[`SkipRedundantNodesTransform matches expected output: skip-nested-linked-fields.graphql 1`] = `
 ~~~~~~~~~~ INPUT ~~~~~~~~~~
 query SkipNestedLinkedFields {
@@ -148,6 +185,48 @@ query SkipNestedFields {
 
 `;
 
+exports[`SkipRedundantNodesTransform matches expected output: skips-with-client-extensions.graphql 1`] = `
+~~~~~~~~~~ INPUT ~~~~~~~~~~
+query SkipWithClientExtensions {
+  viewer {
+    actor {
+      ... on Actor {
+        clientName
+        clientUser {
+          name
+        }
+        clientName
+        clientUser {
+          ... on User {
+            name
+          }
+        }
+      }
+    }
+  }
+}
+
+extend interface Actor {
+  clientName: String
+  clientUser: User
+}
+
+~~~~~~~~~~ OUTPUT ~~~~~~~~~~
+query SkipWithClientExtensions {
+  viewer {
+    actor {
+      ... on Actor {
+        clientName
+        clientUser {
+          name
+        }
+      }
+    }
+  }
+}
+
+`;
+
 exports[`SkipRedundantNodesTransform matches expected output: skips-with-fragment.graphql 1`] = `
 ~~~~~~~~~~ INPUT ~~~~~~~~~~
 fragment ProfilePicture on User {

diff --git a/...__/fixtures/skip-redundant-nodes-transform/dont-skip-with-inline-on-diffent-types.graphql b/...__/fixtures/skip-redundant-nodes-transform/dont-skip-with-inline-on-diffent-types.graphql
@@ -0,0 +1,15 @@
+query DontSkipWithInlineFragmentOnDifferentTypes {
+  viewer {
+    actor {
+      ... on Actor {
+        id
+      }
+      ... on User {
+        id # we currently don't skip this
+        hometown {
+          name
+        }
+      }
+    }
+  }
+}
diff --git a/...ms/__tests__/fixtures/skip-redundant-nodes-transform/skips-with-client-extensions.graphql b/...ms/__tests__/fixtures/skip-redundant-nodes-transform/skips-with-client-extensions.graphql
@@ -0,0 +1,23 @@
+query SkipWithClientExtensions {
+  viewer {
+    actor {
+      ... on Actor {
+        clientName
+        clientUser {
+          name
+        }
+        clientName
+        clientUser {
+          ... on User {
+            name
+          }
+        }
+      }
+    }
+  }
+}
+
+extend interface Actor {
+  clientName: String
+  clientUser: User
+}