Bugfix for validating optimistic updates containing undefined fields

Reviewed By: kassens Differential Revision: D24749857 fbshipit-source-id: ddc91365e5b2cd5591d3da7cda4c62212ddd651a
facebook · Nov 5, 2020 · 6a1586d · 6a1586d
1 parent 2075d38
commit 6a1586d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/packages/relay-runtime/mutations/__tests__/validateMutation-test.js b/packages/relay-runtime/mutations/__tests__/validateMutation-test.js
@@ -551,7 +551,7 @@ describe('validateOptimisticResponse', () => {
         },
       },
       variables: null,
-      shouldWarn: true,
+      shouldWarn: false,
     },
     {
       name: 'Does not log a warning for client-side schema extensions',

diff --git a/packages/relay-runtime/mutations/validateMutation.js b/packages/relay-runtime/mutations/validateMutation.js
@@ -30,6 +30,8 @@ type ValidationContext = {|
 
 const warning = require('warning');
 
+const hasOwnProperty = Object.prototype.hasOwnProperty;
+
 let validateMutation = () => {};
 if (__DEV__) {
   const addFieldToDiff = (path: string, diff: Object, isScalar) => {
@@ -147,15 +149,15 @@ if (__DEV__) {
     context.visitedPaths.add(path);
     switch (field.kind) {
       case 'ScalarField':
-        if (optimisticResponse.hasOwnProperty(fieldName) === false) {
+        if (hasOwnProperty.call(optimisticResponse, fieldName) === false) {
           addFieldToDiff(path, context.missingDiff, true);
         }
         return;
       case 'LinkedField':
         const selections = field.selections;
         if (
           optimisticResponse[fieldName] === null ||
-          (Object.hasOwnProperty(fieldName) &&
+          (hasOwnProperty.call(optimisticResponse, fieldName) &&
             optimisticResponse[fieldName] === undefined)
         ) {
           return;