Fix memory leak in containers

Reviewed By: kassens, JacksonGL Differential Revision: D29659925 fbshipit-source-id: 7af80a0ccb3c8cda1882e1a4c1a28e5f63b8bedd
facebook · Jul 14, 2021 · 5a0c4c6 · 5a0c4c6
1 parent fa3c82f
commit 5a0c4c6
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/packages/relay-runtime/store/RelayModernFragmentSpecResolver.js b/packages/relay-runtime/store/RelayModernFragmentSpecResolver.js
@@ -91,11 +91,14 @@ class RelayModernFragmentSpecResolver implements FragmentSpecResolver {
     this._context = context;
     this._data = {};
     this._fragments = fragments;
-    this._inputProps = props;
     this._props = {};
     this._resolvers = {};
     this._stale = false;
     this._rootIsQueryRenderer = rootIsQueryRenderer;
+    this._inputProps =
+      RelayFeatureFlags.ENABLE_CONTAINERS_SUBSCRIBE_ON_COMMIT === true
+        ? props
+        : {};
 
     this.setProps(props);
   }
@@ -148,8 +151,10 @@ class RelayModernFragmentSpecResolver implements FragmentSpecResolver {
   }
 
   setProps(props: Props): void {
+    if (RelayFeatureFlags.ENABLE_CONTAINERS_SUBSCRIBE_ON_COMMIT === true) {
+      this._inputProps = props;
+    }
     this._props = {};
-    this._inputProps = props;
     const ownedSelectors = getSelectorsFromObject(this._fragments, props);
 
     for (const key in ownedSelectors) {