Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update babel-preset-es2015 to 6.18.0 #268

Merged
merged 1 commit into from
Jan 23, 2017

Conversation

mziemer21
Copy link

@mziemer21 mziemer21 commented Dec 20, 2016

I am getting an error when I try to run my webpack build.

Error in config file!
Error: Options {"loose":true} passed to /Users/my-repo/node_modules/babel-preset-es2015/lib/index.js which does not accept options.
(While processing preset: "/Users/my-repo/node_modules/babel-preset-es2015/lib/index.js")
(While processing preset: "/Users/my-repo/node_modules/babel-preset-es2015/lib/index.js")

This PR added { "loose": true } to es2015 preset, but loose is not supported until es2015 v6.13.0.

I updated babel-preset-es2015 to latest v6.18.0 and all the tests pass.

@mziemer21
Copy link
Author

@benjamn @hzoo could someone take a look at this?

@kangax
Copy link
Contributor

kangax commented Jan 23, 2017

@hzoo looks good?

@hzoo
Copy link
Contributor

hzoo commented Jan 23, 2017

Shouldn't be necessary given ^ but yeah 👍

@kangax kangax merged commit d31acfa into facebook:master Jan 23, 2017
@benjamn
Copy link
Collaborator

benjamn commented Jan 24, 2017

Does this warrant publishing a new npm version?

@hzoo
Copy link
Contributor

hzoo commented Jan 24, 2017

In the OP, this is in reference to #265 which is about building regenerator itself so no I don't think so

@mziemer21
Copy link
Author

@benjamn could you publish a new version? I am getting this error in a different repo's webpack build, not regenerator's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants