Normalize whitespace for transformed JSX code #970
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It currently generates "pretty output" as we agreed upon, it respects original indenting all that, newlines are kept as-is. It also puts
{}
at just after/before the outer()
.There is only one case that I know of currently that produces incorrect output and that is when the attribute name and value are on different lines (see below), I could fix it, but I don't think it's worth the code complexity for something you really shouldn't do, but I could fix it.
I back-tracked on removing trailing spaces after commas, it's not super hard to do, but it's a bit of messy to sort out and I don't find it worthwhile right now. I'll leave it for another PR for now.
I haven't had time to test it extensively yet.
PS. There's a also a bunch of source code lines that got trimmed now that I'm using a better editor (I unintentionally added them with my previous whitespace PR). So that's why there's a bunch of weird "empty" changes below.
Produces: