Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect link #964

Merged
merged 2 commits into from
Jan 27, 2014
Merged

fix incorrect link #964

merged 2 commits into from
Jan 27, 2014

Conversation

bobeagan
Copy link
Contributor

The link to lifecycle methods from the reusable components page was incorrectly pointed to the working with your browser page.

@chenglou
Copy link
Contributor

Hey, have you signed the CLA? Sorry can't check right now.

@sophiebits
Copy link
Collaborator

(The lifecycle methods are actually documented on the "Working with the Browser" page, but perhaps the reference page is a better place to link to.)

@bobeagan
Copy link
Contributor Author

@chenglou yes I have

@bobeagan
Copy link
Contributor Author

If you want to keep it pointing at the "Working with the Browser" page, I'd at least suggest adding #component-lifecycle to link to the correct section of that page.

@zpao
Copy link
Member

zpao commented Jan 24, 2014

@bobeagan Let's do what you suggested and point it to the right anchor on "Working with the Browser". I think that documentation is a bit more conversational and fits into the flow there better.

zpao added a commit that referenced this pull request Jan 27, 2014
@zpao zpao merged commit 0e5dfd3 into facebook:master Jan 27, 2014
@zpao
Copy link
Member

zpao commented Jan 27, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants