Fix an edge case in ReactFiberUpdateQueue
#8975
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jddxf
changed the title
last should be set to update instead of null when the insertion positions are the samelast should be set to update instead of null
|
Good catch! Hmm, typically we'd want to make sure we have a unit test to prevent a regression, but with edge cases like this that are so implementation specific it may not be worth it. Do you mind giving it a shot? |
|
Actually don't sweat it. The path you'd have to take to trigger this edge case is pretty complex. I'll give it a shot before I merge. |
|
That's fine.Thanks! |
|
That’s pretty cool, thank you for finding it. Did you just walk into it reading the source? |
jddxf
changed the title
last should be set to update instead of nullReactFiberUpdateQueue
|
@gaearon Yes.I am trying to understand the fiber :) |
|
So are we. 😄 |
|
lol. |
|
@acdlite Is this still relevant? |
|
I'm going to close since this is outdated. If the bug still exists please re-submit with instructions to reproduce the problem. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct me if I misunderstood something.