Wrap _performComponentUpdate call in try/finally #897
Merged
+27
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes facebook#208. If you attempt a state update with a bad state then the render will fail (and the DOM won't change) but if you switch back to a valid state later then it'll rerender properly.
|
Does it have any effect on performance? I fear that adding a try catch there is going to be bad for perf |
|
With react-bench, not measurably. |
|
I'm 99% sure that this is OK since there isn't that much work done in this frame. |
|
Nice, this is an awesome fix then :) |
petehunt
added a commit
that referenced
this pull request
Jan 15, 2014
Wrap _performComponentUpdate call in try/finally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #208. If you attempt a state update with a bad state then the render
will fail (and the DOM won't change) but if you switch back to a valid state
later then it'll rerender properly.