Use separate feature flag for ReactTestRenderer #8965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ReactDOMFeatureFlags is not reachable from the npm package since it is in a separate build so we need a separate one.
sebmarkbage
force-pushed
the
testrendererflag
branch
from
865afff to
0ec8a37
Compare
|
Want to also add /fiber export? Last time I had this issue, I just made the npm package export Stack version directly. (npm package doesn't currently expose Fiber version at all.) |
|
Hmm never mind, it already exists. |
gaearon
approved these changes
Feb 9, 2017
facebook-github-bot
added
the
React Core Team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ReactDOMFeatureFlags is not reachable from the npm package since it is in a separate build so we need a separate one.