[v15.5] Deprecate React.createFactory #8964
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you have some lint errors, otherwise this looks good.
Nah we only warn in dev. |
koba04
force-pushed
the
deprecate-react-create-factory
branch
from
efe47d6 to
056ccca
Compare
|
@acdlite Thanks! Fixed it! |
|
Sorry about the confusion. :/ We're actually going to keep this because I have some ideas for making it useful for optimizations. We're just going to remove the built-in DOM helpers. |
|
No problem. I'm looking forward to your ideas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for adding deprecation warnings for
React.createFactory, which is listed in #8854.In development environment,
React.createFactoryisReactElementValidator.createFactoryso I added a warning only inReactElementValidator.Should I add this in
ReactElementtoo?