Drop runtime validation and lower case coercion of tag names #8563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we also start using |
gaearon
approved these changes
Dec 13, 2016
| warning( | ||
| isCustomComponent(type, props) || | ||
| type === type.toLowerCase(), | ||
| '<%s /> is using upper-case HTML. Always use lower-case HTML tags ' + |
There was a problem hiding this comment.
Nit: I think it's just "uppercase" and "lowercase", no hyphen.
| if (__DEV__) { | ||
| warning( | ||
| isCustomComponent(type, props) || | ||
| type === type.toLowerCase(), |
There was a problem hiding this comment.
Let's put case match check first? I expect it's going to be true more often.
| warning( | ||
| isCustomComponent(this._tag, props) || | ||
| this._tag === this._currentElement.type, | ||
| '<%s /> is using upper-case HTML. Always use lower-case HTML tags ' + |
There was a problem hiding this comment.
Same as above regarding check order and hyphens.
|
cc @ealf (I know you're not working atm but just pinging for a sanity check later if you want to.) |
sebmarkbage
force-pushed
the
enforcelowercasetags
branch
from
8734ae7
to
572cb0c
Compare
sebmarkbage
commented
Dec 13, 2016
| @@ -408,7 +408,7 @@ const ARTRenderer = ReactFiberReconciler({ | |||
| // Noop | |||
| }, | |||
|
|
|||
| commitUpdate(instance, oldProps, newProps) { | |||
| commitUpdate(instance, type, oldProps, newProps) { | |||
There was a problem hiding this comment.
cc @bvaughn For ART changes.
There was a problem hiding this comment.
Nice! This also eliminates the need for ReactNativeFiber renderer to bundle along the viewConfig with each instance as well.
|
Addressed comments. |
In facebook#2756 we ended up using toLowerCase to allow case insensitive HTML tags. However, this requires extra processing every time we access the tag or at least we need to process it for mount and store it in an extra field which wastes memory. So instead, we can just enforce case sensitivity for HTML since this might matter for the XML namespaces like SVG anyway.
We introduced runtime validation of tag names because we used to generate HTML that was supposed to be inserted into a HTML string which could've been an XSS attack. However, these days we use document.createElement in most cases. That already does its internal validation in the browser which throws. We're now double validating it. Stack still has a path where innerHTML is used and we still need it there. However in Fiber we can remove it completely.
Instead of reading it from the DOM node.
sebmarkbage
force-pushed
the
enforcelowercasetags
branch
from
572cb0c
to
6c1592f
Compare
|
Should tag this as |
|
sure |
bvaughn
pushed a commit
to bvaughn/react
that referenced
this pull request
Dec 14, 2016
Also removed the no-longer-necessary viewConfig from the NativeHostComponent. This config can be retrieved when necessary from commitUpdate() thanks to the newly-added type param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2756 we ended up using toLowerCase to allow case insensitive HTML tags. However, this requires extra processing every time we access the tag or at least we need to process it for mount and store it in an extra field which wastes memory.
So instead, we can just enforce case sensitivity for HTML since this might matter for the XML namespaces like SVG anyway.
We introduced runtime validation of tag names because we used to generate HTML that was supposed to be inserted into a HTML string which could've been an XSS attack.
However, these days we use
document.createElement(tagName)in most cases. That already does its internal validation in the browser which throws. We're now double validating it. Stack still has a path where innerHTML is used and with this change we still apply validation there. However in Fiber we can remove it completely since we only usedocument.createElement(tagName)and never generate HTML.