Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lists-and-keys.md #8090

Merged
merged 1 commit into from
Oct 26, 2016
Merged

Update lists-and-keys.md #8090

merged 1 commit into from
Oct 26, 2016

Conversation

Jaehlee11
Copy link
Contributor

Before submitting a pull request, please make sure the following is done...

  1. Fork the repo and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.
  6. If you haven't already, complete the CLA.

There is mismatching variable name both definition and usage.
In line 156, an argument name called item is change to match the usage in line 158.

There is mismatching variable name both definition and usage.
In line 156, an argument name called item is change to match the usage in line 158.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon
Copy link
Collaborator

gaearon commented Oct 26, 2016

Thank you!

gaearon pushed a commit that referenced this pull request Oct 27, 2016
There is mismatching variable name both definition and usage.
In line 156, an argument name called item is change to match the usage in line 158.
acusti pushed a commit to brandcast/react that referenced this pull request Mar 15, 2017
There is mismatching variable name both definition and usage.
In line 156, an argument name called item is change to match the usage in line 158.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants