Bailout if the element and the context is unchanged properly #7819
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, We use
===
to check if a context is changed before bailing out, but we create a new context everytime a compnent is updated, regardless the origin context provided by the consumer is unchanged.As a result,
===
would always returnfalse
unless the context isundefined
. That is, when there is a context, a component would never be bailed out. Specifically, If we usereact-redux
,react-router
,react-intl
or any other lib which provides a context, we would get no bailout optimization.To fix this, I suggest we use
shallowEqual
instead of===
. But I am not sure it would introduce a breaking change or not. I have made this change in this PR along with a test.