Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid validation warning when inputs change type #7333

Merged
merged 1 commit into from
Jul 23, 2016
Merged

Avoid validation warning when inputs change type #7333

merged 1 commit into from
Jul 23, 2016

Commits on Jul 23, 2016

  1. Avoid validation warning when inputs change type 

    For controlled inputs, `updateWrapper` was getting called before the
`type` prop had a chance to update. This could lead to a case where
switching from the `text` to `number` type caused a validation error
that would prevent the proper input value from being assigned.

This commit moves the call to `ReactDOMInput.updateWrapper` below
`_updateProperties` to avoid this situation.
    @nhunzaker
    nhunzaker committed Jul 23, 2016
    Configuration menu
    Copy the full SHA
    8272e8f View commit details
    Browse the repository at this point in the history