Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom elements extending native ones #6570

Merged
merged 1 commit into from
Apr 29, 2016
Merged

Conversation

jscissr
Copy link
Contributor

@jscissr jscissr commented Apr 21, 2016

...by passing the is attribute as the second param to createElement.
Documentation: http://webcomponents.org/polyfills/custom-elements/

...by passing the `is` attribute as the second param to `createElement`.
See http://webcomponents.org/polyfills/custom-elements/
@facebook-github-bot
Copy link

@jscissr updated the pull request.

@jimfb
Copy link
Contributor

jimfb commented Apr 22, 2016

I suppose this technically fixes a regression, since we previously rendered new elements to markup.

@jimfb jimfb self-assigned this Apr 22, 2016
@gaearon gaearon added this to the 15.0.x milestone Apr 27, 2016
@zpao zpao merged commit 3d31361 into facebook:master Apr 29, 2016
@jscissr jscissr deleted the custom-is branch April 29, 2016 22:42
zpao pushed a commit that referenced this pull request May 10, 2016
...by passing the `is` attribute as the second param to `createElement`.
See http://webcomponents.org/polyfills/custom-elements/
(cherry picked from commit 3d31361)
@zpao zpao modified the milestones: 15.0.x, 15.0.3 May 10, 2016
@zpao zpao modified the milestones: 15.0.3, 15.y.z, 15.1.0 May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants