Add TapEventPlugin to ReactWithAddons #470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. |
|
@zpao are you cool with this? I had to hack around it here: https://github.com/petehunt/react-touch/blob/gh-pages/src/thirdparty/TapEventPlugin.js |
add eventpluginhub Revert "add eventpluginhub" This reverts commit 25560b025efb19b7e41a526c22b9f234d92a6e99. injectTapEventPlugin docs add responder document it
|
I would really like us to prioritize getting this in so we can use this stuff easily. |
|
I found a better way to do this in #627 |
|
The implication being that you're expected to use browserify? |
|
More like any CommonJS build system -- I've tested that PR with browserify and webpack, both worked. |
|
Also -- eventually I'd like to take the approach that we take the CommonJS build of these addons and package it for the browser. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat lame fix for #436