Added warning when calling methods on a released event. #4635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvinerikson
force-pushed
the
event-pooling-warning
branch
from
636fae1
to
9fffa02
Compare
edvinerikson
force-pushed
the
event-pooling-warning
branch
from
9fffa02
to
34af8f8
Compare
|
I think this code will result in a warning in all instances where preventDefault is used. I think the warning should only be logged if |
|
If I have understood the behavior of the warning package, it should be correct as it is now. |
|
Sorry I missed that. Yes it should work correctly. +1 |
|
this seems nice to me |
|
Looks good, thanks! |
jimfb
added a commit
that referenced
this pull request
Aug 31, 2015
Added warning when calling methods on a released event.
sophiebits
added a commit
that referenced
this pull request
Aug 31, 2015
Fix code style/grammar on synthetic event warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4514
Warns only if
__DEV__is set.Not quite sure that I got the smoothest message in there, would appreciate some feedback (on both the message and the code).
Changed behavior:
It exits the method if
nativeEventis falsy.We should probably create a short-link to the docs.
cc @jimfb