Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

traverseAllChildren code clarity #4367

Merged
merged 1 commit into from
Jul 23, 2015
Merged

traverseAllChildren code clarity #4367

merged 1 commit into from
Jul 23, 2015

Conversation

Simek
Copy link
Contributor

@Simek Simek commented Jul 13, 2015

Simple change - repetitive code extracted into variable.

@zpao
Copy link
Member

zpao commented Jul 23, 2015

Thanks!

zpao added a commit that referenced this pull request Jul 23, 2015
@zpao
Merge pull request #4367 from Simek/traverse-children-cleanup
ac5e5d7 
traverseAllChildren code clarity
@zpao zpao merged commit ac5e5d7 into facebook:master Jul 23, 2015
@sophiebits
Copy link
Collaborator

Nice, much better.

This was referenced Nov 30, 2023
Open
Open
Open
This was referenced Feb 11, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Simek @zpao @sophiebits @facebook-github-bot