-
Notifications
You must be signed in to change notification settings - Fork 46.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update script sources to be even with the example file ... #4121
Conversation
<script src="https://fb.me/react-{{site.react_version}}.js"></script> | ||
<script src="https://fb.me/JSXTransformer-{{site.react_version}}.js"></script> | ||
<script src="https://code.jquery.com/jquery-2.1.3.min.js"></script> | ||
<script src="https://cdnjs.cloudflare.com/ajax/libs/react/0.13.0/react.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should leave this with {{site.react_version}}
in there. That ensures we don't need to update this page for every release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zpao should be fixed with 4564e555b3b815f1ac8fcf9fd46eb61412b556aa ~
Great. 1 more request - could you flatten these to a single commit? |
…ct-tutorial repo ... apply to japanese and korean translation (+2 squashed commit) Squashed commit: [4564e55] Ensures we don't need to update this page for every release. [b0d60f9] update script sources to be even with the example file in reactjs/react-tutorial repo
ping @zpao -- don't know if you had been notified that commits have been flatten as requested. |
Ah, nope. Github doesn't send notifications for commit changes. Looks great, thanks! |
update script sources to be even with the example file ...
Cheers! You tested my git-via-sourcetree knowledge there, to squash commits to one ;) |
... in reactjs/react-tutorial repo
cf. reactjs/react-tutorial#57