Add shallowCompare module and use it in PureRenderMixin + tests #3355
+176
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
shallowCompare
and adds tests for PureRenderMixin.This allows the following pattern:
Not super happy about this API.
Component.prototype.shouldComponentUpdate = React.addons.shallowCompare
seems like the better choice for the common case, but then using it would require callingReact.addons.shallowCompare.apply(this, arguments)
.