-
Notifications
You must be signed in to change notification settings - Fork 47.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[playground] Fixes #31331 #31561
[playground] Fixes #31331 #31561
Conversation
1) Adds support for 'use memo' and 'use no memo' 2) Cleanup E2E test cases a bit 3) Adds test cases for use memo 4) Added documentation to run test cases
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @subbu963! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
… issue in chromium driver on CI?). Reverted back to hash based compilation
1) removing redundant map and doing the compilation check while traversing itself 2) cleanup of checkExplicitMemoizeDirectives to return a string instead 3) compilation flag changed to `compilationEnabled` for accuracy 4) fixing of improperly cased variabled names in e2e test files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a few more tests covering module scoped "use no memo" and a nested one?
…nctions and expression names werent getting printed
@poteto added a few more test cases like you asked |
Thanks! |
Summary
There is a bug in playground(#31331) which doesnt support 'use memo' or 'use no memo' directives. Its misleading while debugging components in the playground
How did you test this change?
Ran test cases and added a few extra test cases as well
Changes
Implementation
parseFunctions
returns a set of functions to be compiled. But, it doesnt filter out/handle memoized opted/un-opted functions using directives.ive just created a
compile
flag to enable/disable compiling hereThen I am just skipping those functions from getting compile here