Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit try/finally around console patching #31286

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Oct 18, 2024

Otherwise if something errors they can be left patched.

Review without whitespace

@sebmarkbage sebmarkbage requested a review from hoxyq October 18, 2024 15:02
Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 3:06pm

@react-sizebot
Copy link

Comparing: 1ce58dd...1dc21e2

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js +0.06% 506.53 kB 506.86 kB +0.03% 90.68 kB 90.70 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js +0.06% 511.47 kB 511.79 kB +0.02% 91.40 kB 91.42 kB
facebook-www/ReactDOM-prod.classic.js +0.05% 603.93 kB 604.26 kB +0.03% 106.88 kB 106.92 kB
facebook-www/ReactDOM-prod.modern.js +0.06% 580.15 kB 580.48 kB +0.03% 102.97 kB 103.01 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-rc/react/cjs/react-jsx-dev-runtime.development.js +1.21% 24.37 kB 24.66 kB +0.02% 5.89 kB 5.89 kB
oss-stable-semver/react/cjs/react-jsx-dev-runtime.development.js +1.21% 24.37 kB 24.66 kB +0.02% 5.89 kB 5.89 kB
oss-stable/react/cjs/react-jsx-dev-runtime.development.js +1.21% 24.37 kB 24.66 kB +0.02% 5.89 kB 5.89 kB
oss-stable-rc/react/cjs/react-jsx-runtime.development.js +1.20% 24.43 kB 24.73 kB +0.03% 5.89 kB 5.89 kB
oss-stable-semver/react/cjs/react-jsx-runtime.development.js +1.20% 24.43 kB 24.73 kB +0.03% 5.89 kB 5.89 kB
oss-stable/react/cjs/react-jsx-runtime.development.js +1.20% 24.43 kB 24.73 kB +0.03% 5.89 kB 5.89 kB
facebook-react-native/react/cjs/JSXDEVRuntime-dev.js +1.19% 24.63 kB 24.93 kB +0.13% 5.99 kB 6.00 kB
facebook-react-native/react/cjs/JSXRuntime-dev.js +1.19% 24.70 kB 24.99 kB +0.13% 6.00 kB 6.01 kB
oss-stable-rc/react/cjs/react-jsx-runtime.react-server.development.js +1.18% 24.96 kB 25.25 kB +0.03% 6.02 kB 6.02 kB
oss-stable-semver/react/cjs/react-jsx-runtime.react-server.development.js +1.18% 24.96 kB 25.25 kB +0.03% 6.02 kB 6.02 kB
oss-stable/react/cjs/react-jsx-runtime.react-server.development.js +1.18% 24.96 kB 25.25 kB +0.03% 6.02 kB 6.02 kB
oss-stable-rc/react/cjs/react-jsx-dev-runtime.react-server.development.js +1.18% 24.96 kB 25.26 kB +0.03% 6.02 kB 6.02 kB
oss-stable-semver/react/cjs/react-jsx-dev-runtime.react-server.development.js +1.18% 24.96 kB 25.26 kB +0.03% 6.02 kB 6.02 kB
oss-stable/react/cjs/react-jsx-dev-runtime.react-server.development.js +1.18% 24.96 kB 25.26 kB +0.03% 6.02 kB 6.02 kB
facebook-www/JSXDEVRuntime-dev.modern.js +0.89% 33.11 kB 33.40 kB +0.13% 7.72 kB 7.73 kB
facebook-www/JSXDEVRuntime-dev.classic.js +0.88% 33.24 kB 33.53 kB +0.13% 7.74 kB 7.75 kB
oss-stable-rc/react/cjs/react.react-server.development.js +0.73% 40.17 kB 40.46 kB +0.02% 9.20 kB 9.20 kB
oss-stable-semver/react/cjs/react.react-server.development.js +0.73% 40.17 kB 40.46 kB +0.02% 9.20 kB 9.20 kB
oss-stable/react/cjs/react.react-server.development.js +0.73% 40.19 kB 40.48 kB +0.02% 9.22 kB 9.22 kB
oss-stable-rc/react/cjs/react.development.js +0.53% 55.57 kB 55.87 kB +0.22% 12.39 kB 12.42 kB
oss-stable-semver/react/cjs/react.development.js +0.53% 55.57 kB 55.87 kB +0.22% 12.39 kB 12.42 kB
oss-stable/react/cjs/react.development.js +0.53% 55.59 kB 55.89 kB +0.19% 12.42 kB 12.44 kB
facebook-react-native/react/cjs/React-dev.js +0.47% 62.60 kB 62.90 kB +0.05% 13.77 kB 13.78 kB
facebook-www/React-dev.modern.js +0.40% 74.10 kB 74.39 kB +0.07% 16.23 kB 16.24 kB
facebook-www/React-dev.classic.js +0.39% 74.96 kB 75.25 kB +0.06% 16.40 kB 16.41 kB

Generated by 🚫 dangerJS against c6208a4

@sebmarkbage sebmarkbage merged commit b8ae38f into facebook:main Oct 18, 2024
184 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 18, 2024
Otherwise if something errors they can be left patched.

[Review without
whitespace](https://github.com/facebook/react/pull/31286/files?w=1)

DiffTrain build for [b8ae38f](b8ae38f)
github-actions bot pushed a commit that referenced this pull request Oct 18, 2024
Otherwise if something errors they can be left patched.

[Review without
whitespace](https://github.com/facebook/react/pull/31286/files?w=1)

DiffTrain build for [b8ae38f](b8ae38f)
hoxyq added a commit that referenced this pull request Jan 16, 2025
List of changes in this release:

* fix[DevTools]: fix HostComponent naming in filters for Native
([hoxyq](https://github.com/hoxyq) in
[#32086](#32086))
* Fix copy functionality in Firefox ([V3RON](https://github.com/V3RON)
in [#32077](#32077))
* chore[DevTools]: don't use batchedUpdate
([hoxyq](https://github.com/hoxyq) in
[#32074](#32074))
* Prevent crash when starting consecutive profiling sessions
([V3RON](https://github.com/V3RON) in
[#32066](#32066))
* fix[DevTools/Tree]: only scroll to item when panel is visible
([hoxyq](https://github.com/hoxyq) in
[#32018](#32018))
* feat[Tree]: set initial scroll offset when inspected element index is
set ([hoxyq](https://github.com/hoxyq) in
[#31968](#31968))
* DevTools: merge element fields in TreeStateContext
([hoxyq](https://github.com/hoxyq) in
[#31956](#31956))
* DevTools: fix initial host instance selection
([hoxyq](https://github.com/hoxyq) in
[#31892](#31892))
* chore[DevTools/Tree]: don't pre-select root element and remove unused
code ([hoxyq](https://github.com/hoxyq) in
[#32015](#32015))
* chore[DevTools/TraceUpdates]: display names by default
([hoxyq](https://github.com/hoxyq) in
[#32019](#32019))
* Add ViewTransitionComponent to Stacks and DevTools
([sebmarkbage](https://github.com/sebmarkbage) in
[#32034](#32034))
* Add <ViewTransition> Component
([sebmarkbage](https://github.com/sebmarkbage) in
[#31975](#31975))
* chore[react-devtools-shell]: disable warnings in dev server overlay
([hoxyq](https://github.com/hoxyq) in
[#32005](#32005))
* DevTools: fork FastRefresh test for <18 versions of React
([hoxyq](https://github.com/hoxyq) in
[#31893](#31893))
* Show component names while highlighting renders
([piotrski](https://github.com/piotrski) in
[#31577](#31577))
* allow non-coercible objects in formatConsoleArgumentsToSingleString
([henryqdineen](https://github.com/henryqdineen) in
[#31444](#31444))
* Remove enableRefAsProp feature flag
([kassens](https://github.com/kassens) in
[#30346](#30346))
* [flow] Eliminate usage of more than 1-arg `React.AbstractComponent` in
React codebase ([SamChou19815](https://github.com/SamChou19815) in
[#31314](#31314))
* Audit try/finally around console patching
([sebmarkbage](https://github.com/sebmarkbage) in
[#31286](#31286))
* tests[react-devtools]: added tests for Compiler integration
([hoxyq](https://github.com/hoxyq) in
[#31241](#31241))
* Add Bridge types for Fusebox
([EdmondChuiHW](https://github.com/EdmondChuiHW) in
[#31274](#31274))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants