[rcr] Reexport React.__COMPILER_RUNTIME.c or fallback to polyfill #31140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
This was referenced Oct 7, 2024
This was referenced Oct 8, 2024
poteto
added a commit
that referenced
this pull request
Oct 11, 2024
In #31140 we switched over the uMC polyfill to use memo instead of state since memo would FastRefresh properly. However this busted devtools' badging of compiled components; this PR fixes it. TODO: tests
poteto
added a commit
that referenced
this pull request
Oct 14, 2024
In #31140 we switched over the uMC polyfill to use memo instead of state since memo would FastRefresh properly. However this busted devtools' badging of compiled components; this PR fixes it. TODO: tests Co-authored-by: Ruslan Lesiutin <rdlesyutin@gmail.com>
hoxyq
added a commit
that referenced
this pull request
Oct 15, 2024
In #31140 we switched over the uMC polyfill to use memo instead of state since memo would FastRefresh properly. However this busted devtools' badging of compiled components; this PR fixes it. TODO: tests Co-authored-by: Ruslan Lesiutin <rdlesyutin@gmail.com> --------- Co-authored-by: Ruslan Lesiutin <rdlesyutin@gmail.com>
gaearon
reviewed
Nov 17, 2024
| // This symbol is added to tell the react devtools that this array is from | ||
| // useMemoCache. | ||
| // @ts-ignore | ||
| $[$empty] = true; |
There was a problem hiding this comment.
Just looking at this now — I know this already existed, but isn't there a concern that this would mess with the hidden class or something? Setting a non-array property on an array seems dicey.
There was a problem hiding this comment.
cc @poteto @josephsavona this would be good to double-check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the standalone
react-compiler-runtimepackage toeither re-export
React.__COMPILER_RUNTIME.cor to use a userspacepolyfill.