Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flight] Add react-stack-bottom-frame to console replaying #30926

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

sebmarkbage
Copy link
Collaborator

Any time we're creating a stack trace we should have a react-stack-bottom-frame so we know what to filter out.

This is the same thing we already do for createFakeJSXCallStackInDEV but we should do that when replaying logs too.

Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 10:53pm

@react-sizebot
Copy link

Comparing: 0dbacf2...ce0b29e

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 505.22 kB 505.22 kB = 90.29 kB 90.29 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 512.41 kB 512.41 kB = 91.50 kB 91.50 kB
facebook-www/ReactDOM-prod.classic.js = 600.74 kB 600.74 kB = 106.27 kB 106.27 kB
facebook-www/ReactDOM-prod.modern.js = 577.03 kB 577.03 kB = 102.41 kB 102.41 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-rc/react-client/cjs/react-client-flight.development.js +1.47% 82.99 kB 84.22 kB +1.61% 15.20 kB 15.44 kB
oss-stable-semver/react-client/cjs/react-client-flight.development.js +1.47% 82.99 kB 84.22 kB +1.61% 15.20 kB 15.44 kB
oss-stable/react-client/cjs/react-client-flight.development.js +1.47% 83.01 kB 84.24 kB +1.60% 15.22 kB 15.46 kB
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +1.18% 80.94 kB 81.90 kB +1.56% 15.31 kB 15.55 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +1.18% 80.94 kB 81.90 kB +1.56% 15.31 kB 15.55 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +1.18% 80.99 kB 81.95 kB +1.57% 15.33 kB 15.57 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +1.16% 90.39 kB 91.44 kB +1.80% 17.07 kB 17.38 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +1.16% 90.39 kB 91.44 kB +1.80% 17.07 kB 17.38 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +1.16% 90.39 kB 91.44 kB +1.80% 17.07 kB 17.38 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +1.16% 82.81 kB 83.76 kB +1.57% 15.70 kB 15.95 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +1.16% 82.81 kB 83.76 kB +1.57% 15.70 kB 15.95 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +1.16% 82.85 kB 83.81 kB +1.57% 15.72 kB 15.97 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +1.15% 83.26 kB 84.22 kB +1.57% 15.81 kB 16.06 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +1.15% 83.26 kB 84.22 kB +1.57% 15.81 kB 16.06 kB
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +1.15% 85.11 kB 86.09 kB +1.45% 16.27 kB 16.51 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +1.15% 85.11 kB 86.09 kB +1.45% 16.27 kB 16.51 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +1.15% 85.11 kB 86.09 kB +1.45% 16.27 kB 16.51 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +1.15% 83.30 kB 84.26 kB +1.58% 15.83 kB 16.08 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +1.15% 91.19 kB 92.24 kB +1.78% 17.24 kB 17.55 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +1.15% 91.19 kB 92.24 kB +1.78% 17.24 kB 17.55 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +1.15% 91.19 kB 92.24 kB +1.78% 17.24 kB 17.55 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +1.12% 87.33 kB 88.31 kB +1.51% 16.74 kB 16.99 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +1.12% 87.33 kB 88.31 kB +1.51% 16.74 kB 16.99 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +1.12% 87.33 kB 88.31 kB +1.51% 16.74 kB 16.99 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +1.10% 88.70 kB 89.68 kB +1.52% 17.03 kB 17.29 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +1.10% 88.70 kB 89.68 kB +1.52% 17.03 kB 17.29 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +1.10% 88.70 kB 89.68 kB +1.52% 17.03 kB 17.29 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +1.10% 88.72 kB 89.70 kB +1.50% 17.01 kB 17.27 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +1.10% 88.72 kB 89.70 kB +1.50% 17.01 kB 17.27 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +1.10% 88.72 kB 89.70 kB +1.50% 17.01 kB 17.27 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.73% 88.83 kB 89.48 kB +0.12% 16.90 kB 16.92 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.71% 90.69 kB 91.34 kB +0.13% 17.29 kB 17.31 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.71% 91.14 kB 91.79 kB +0.13% 17.40 kB 17.43 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.70% 93.03 kB 93.67 kB +0.07% 17.89 kB 17.91 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.68% 95.25 kB 95.90 kB +0.12% 18.37 kB 18.39 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.67% 96.62 kB 97.26 kB +0.12% 18.61 kB 18.64 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.67% 96.63 kB 97.28 kB +0.12% 18.60 kB 18.62 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.59% 98.43 kB 99.01 kB +0.12% 18.73 kB 18.76 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.59% 99.23 kB 99.81 kB +0.12% 18.91 kB 18.93 kB
oss-experimental/react-client/cjs/react-client-flight.development.js +0.53% 90.88 kB 91.36 kB +0.24% 16.78 kB 16.82 kB

Generated by 🚫 dangerJS against b73dae3

@sebmarkbage sebmarkbage merged commit 49825c0 into facebook:main Sep 9, 2024
184 checks passed
gnoff pushed a commit to vercel/next.js that referenced this pull request Sep 12, 2024
**breaking change for canary users: Bumps peer dependency of React from
`19.0.0-rc-7771d3a7-20240827` to `19.0.0-rc-94e652d5-20240912`**

[diff
facebook/react@7771d3a7...94e652d5](facebook/react@7771d3a...94e652d)

<details>
<summary>React upstream changes</summary>

- facebook/react#30952
- facebook/react#30950
- facebook/react#30946
- facebook/react#30934
- facebook/react#30947
- facebook/react#30945
- facebook/react#30938
- facebook/react#30936
- facebook/react#30879
- facebook/react#30888
- facebook/react#30931
- facebook/react#30930
- facebook/react#30832
- facebook/react#30929
- facebook/react#30926
- facebook/react#30925
- facebook/react#30905
- facebook/react#30900
- facebook/react#30910
- facebook/react#30906
- facebook/react#30899
- facebook/react#30919
- facebook/react#30708
- facebook/react#30907
- facebook/react#30897
- facebook/react#30896
- facebook/react#30895
- facebook/react#30887
- facebook/react#30889
- facebook/react#30893
- facebook/react#30892
- facebook/react#30891
- facebook/react#30882
- facebook/react#30881
- facebook/react#30870
- facebook/react#30849
- facebook/react#30878
- facebook/react#30865
- facebook/react#30869
- facebook/react#30875
- facebook/react#30800
- facebook/react#30762
- facebook/react#30831
- facebook/react#30866
- facebook/react#30853
- facebook/react#30850
- facebook/react#30847
- facebook/react#30842
- facebook/react#30837
- facebook/react#30848
- facebook/react#30844
- facebook/react#30839
- facebook/react#30802
- facebook/react#30841
- facebook/react#30827
- facebook/react#30826
- facebook/react#30825
- facebook/react#30824
- facebook/react#30840
- facebook/react#30838
- facebook/react#30836
- facebook/react#30819
- facebook/react#30816
- facebook/react#30814
- facebook/react#30813
- facebook/react#30812
- facebook/react#30811

</details>

---------

Co-authored-by: vercel-release-bot <infra+release@vercel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants