Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compiler] Allow inferred non-optional paths when manual deps were optional #30816

Merged
merged 4 commits into from
Aug 28, 2024
Merged

[compiler] Allow inferred non-optional paths when manual deps were optional #30816

merged 4 commits into from
Aug 28, 2024

Commits on Aug 26, 2024

  1. [compiler] Allow inferred non-optional paths when manual deps were op… 

    …tional

If the inferred deps are more precise (non-optional) than the manual deps (optional) it should pass validation.

The other direction also seems like it would be fine - inferring optional deps when the original was non-optional - but for now let's keep the "at least as precise" rule.

[ghstack-poisoned]
    @josephsavona
    josephsavona committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    6672089 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Update on "[compiler] Allow inferred non-optional paths when manual d… 

    …eps were optional"

If the inferred deps are more precise (non-optional) than the manual deps (optional) it should pass validation.

The other direction also seems like it would be fine - inferring optional deps when the original was non-optional - but for now let's keep the "at least as precise" rule.

[ghstack-poisoned]
    @josephsavona
    josephsavona committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    c09309d View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Update on "[compiler] Allow inferred non-optional paths when manual d… 

    …eps were optional"

If the inferred deps are more precise (non-optional) than the manual deps (optional) it should pass validation.

The other direction also seems like it would be fine - inferring optional deps when the original was non-optional - but for now let's keep the "at least as precise" rule.

[ghstack-poisoned]
    @josephsavona
    josephsavona committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    1bbb135 View commit details
    Browse the repository at this point in the history

  2. Update on "[compiler] Allow inferred non-optional paths when manual d… 

    …eps were optional"

If the inferred deps are more precise (non-optional) than the manual deps (optional) it should pass validation.

The other direction also seems like it would be fine - inferring optional deps when the original was non-optional - but for now let's keep the "at least as precise" rule.

[ghstack-poisoned]
    @josephsavona
    josephsavona committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    7782549 View commit details
    Browse the repository at this point in the history