Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fizz] use microtasks rather than tasks when scheduling work while prerendering #30770

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented Aug 21, 2024

Similar to #30768 we want to schedule work during prerendering in microtasks both for the root task and pings. We continue to schedule flushes as Tasks to allow as much work to be batched up as possible.

…erendering

Similar to facebook#30768 we want to schedule work during prerendering in microtasks both for the root task and pings. We continue to schedule flushes as Tasks to allow as much work to be batched up as possible.
Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 5:09am

@react-sizebot
Copy link

Comparing: dc32c7f...9e8392c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 500.37 kB 500.37 kB = 89.80 kB 89.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 507.50 kB 507.50 kB = 90.96 kB 90.96 kB
facebook-www/ReactDOM-prod.classic.js = 595.24 kB 595.24 kB = 105.55 kB 105.55 kB
facebook-www/ReactDOM-prod.modern.js = 571.54 kB 571.54 kB = 101.75 kB 101.75 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-rc/react-dom/cjs/react-dom-server.edge.production.js +0.35% 220.84 kB 221.62 kB +0.43% 41.22 kB 41.40 kB
oss-stable-semver/react-dom/cjs/react-dom-server.edge.production.js +0.35% 220.84 kB 221.62 kB +0.43% 41.22 kB 41.40 kB
oss-stable/react-dom/cjs/react-dom-server.edge.production.js +0.35% 220.91 kB 221.68 kB +0.43% 41.25 kB 41.42 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.production.js +0.31% 248.33 kB 249.11 kB +0.41% 44.58 kB 44.77 kB
oss-stable-rc/react-dom/cjs/react-dom-server.browser.production.js +0.28% 215.96 kB 216.55 kB +0.41% 39.35 kB 39.51 kB
oss-stable-semver/react-dom/cjs/react-dom-server.browser.production.js +0.28% 215.96 kB 216.55 kB +0.41% 39.35 kB 39.51 kB
oss-stable/react-dom/cjs/react-dom-server.browser.production.js +0.27% 216.02 kB 216.62 kB +0.41% 39.38 kB 39.54 kB
oss-stable-rc/react-server/cjs/react-server.production.js +0.26% 107.48 kB 107.75 kB +0.15% 19.74 kB 19.77 kB
oss-stable-semver/react-server/cjs/react-server.production.js +0.26% 107.48 kB 107.75 kB +0.15% 19.74 kB 19.77 kB
oss-stable/react-server/cjs/react-server.production.js +0.26% 107.48 kB 107.75 kB +0.15% 19.74 kB 19.77 kB
oss-stable-rc/react-dom/cjs/react-dom-server.edge.development.js +0.25% 357.08 kB 357.96 kB +0.26% 65.32 kB 65.49 kB
oss-stable-semver/react-dom/cjs/react-dom-server.edge.development.js +0.25% 357.08 kB 357.96 kB +0.26% 65.32 kB 65.49 kB
oss-stable/react-dom/cjs/react-dom-server.edge.development.js +0.25% 357.15 kB 358.03 kB +0.27% 65.34 kB 65.52 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.production.js +0.24% 242.88 kB 243.48 kB +0.39% 42.60 kB 42.77 kB
oss-experimental/react-server/cjs/react-server.production.js +0.23% 120.88 kB 121.16 kB +0.14% 21.63 kB 21.66 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.development.js +0.22% 396.72 kB 397.60 kB +0.24% 69.64 kB 69.81 kB

Generated by 🚫 dangerJS against 6d561d9

@gnoff gnoff merged commit ab24f64 into facebook:main Aug 21, 2024
185 checks passed
@gnoff gnoff deleted the fizz-prerender-timing branch August 21, 2024 14:55
github-actions bot pushed a commit that referenced this pull request Aug 21, 2024
…erendering (#30770)

Similar to #30768 we want to
schedule work during prerendering in microtasks both for the root task
and pings. We continue to schedule flushes as Tasks to allow as much
work to be batched up as possible.

DiffTrain build for [ab24f64](ab24f64)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants