Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTools] Rename Fiber to Element in the Bridge Protocol and RendererInterface #30490

Merged
merged 6 commits into from
Jul 29, 2024

Commits on Jul 27, 2024

  1. Rename bridge protocol Fiber to Element

    Nothing in the front end should really know anything about what kind of
    renderer implementation we're inspecting and indeed it's already not always
    a "Fiber" in the legacy renderer and won't be for Server Components.
    
    We typically refer to this as a "Component Instance" but the front end
    currently refers to it as an Element as it historically grew from the
    DOM Elements tab UI.
    sebmarkbage committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    c34155d View commit details
    Browse the repository at this point in the history
  2. Rename RendererInterface from Fiber to Element

    Except where it's actually expecting a Fiber specifically.
    sebmarkbage committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    b742aac View commit details
    Browse the repository at this point in the history
  3. Rename local helpers

    sebmarkbage committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    57f565f View commit details
    Browse the repository at this point in the history
  4. Move renderer.js and DevToolsFiberComponentStack.js into backend/fiber

    These are at the same level as backend/legacy.
    
    This clarifies that anything outside of this folder shouldn't ideally refer
    to a "Fiber".
    sebmarkbage committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    7e87569 View commit details
    Browse the repository at this point in the history
  5. Move shared utilities into backend/shared

    Clears the root folder of the backend a bit to clarify which parts are entry points.
    
    This follows from these same files being in packages/shared/ since they're
    shared by multiple renderers.
    sebmarkbage committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    075dc80 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2024

  1. Don't expose getComponentStackForFiber and getSourceForFiber

    These are not used outside the renderer itself and shouldn't communicate
    via Fibers externally.
    
    console.js calls getStackByFiberInDevAndProd separately but that's
    a separate source of abstraction violations.
    sebmarkbage committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    739948a View commit details
    Browse the repository at this point in the history