Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove allowConcurrentByDefault flag #30445

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

jackpope
Copy link
Contributor

Following #30436

Concurrent by default strategy has been unshipped. Here we clean up the allowConcurrentByDefault path and related logic/tests.

For now, this keeps the concurrentUpdatesByDefaultOverride argument in createContainer and createHydrationContainer and ignores the value to prevent more breaking changes to react-reconciler in the RC stage.

Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 4:56pm

@eps1lon
Copy link
Collaborator

eps1lon commented Jul 24, 2024

Need to wait for https://github.com/facebook/react/actions/runs/10079081825 to complete or rebase so that sizebot gets a working merge base

@react-sizebot
Copy link

Comparing: c0b76a6...c127fbb

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 501.44 kB 501.39 kB = 89.98 kB 89.96 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 506.26 kB 506.21 kB = 90.68 kB 90.66 kB
facebook-www/ReactDOM-prod.classic.js = 599.78 kB 598.83 kB = 105.88 kB 105.76 kB
facebook-www/ReactDOM-prod.modern.js = 575.83 kB 574.94 kB = 102.15 kB 101.99 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js = 343.72 kB 343.02 kB = 60.14 kB 60.02 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js = 146.80 kB 146.48 kB +0.07% 27.08 kB 27.10 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js = 319.78 kB 319.08 kB = 56.67 kB 56.54 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js = 146.65 kB 146.33 kB +0.07% 27.02 kB 27.04 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js = 145.70 kB 145.38 kB +0.06% 26.82 kB 26.83 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js = 145.54 kB 145.21 kB +0.07% 26.76 kB 26.78 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js = 139.17 kB 138.84 kB +0.06% 25.79 kB 25.80 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js = 145.07 kB 144.30 kB = 26.79 kB 26.74 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js = 144.92 kB 144.15 kB = 26.72 kB 26.68 kB

Generated by 🚫 dangerJS against e09673d

@jackpope jackpope merged commit 14a4699 into facebook:main Jul 25, 2024
187 checks passed
@jackpope jackpope deleted the concurrent-by-default-cleanup-2 branch July 25, 2024 15:59
github-actions bot pushed a commit that referenced this pull request Jul 25, 2024
Following #30436

Concurrent by default strategy has been unshipped. Here we clean up the
`allowConcurrentByDefault` path and related logic/tests.

For now, this keeps the `concurrentUpdatesByDefaultOverride` argument in
`createContainer` and `createHydrationContainer` and ignores the value
to prevent more breaking changes to `react-reconciler` in the RC stage.

DiffTrain build for commit 14a4699.
github-actions bot pushed a commit that referenced this pull request Jul 25, 2024
Following #30436

Concurrent by default strategy has been unshipped. Here we clean up the
`allowConcurrentByDefault` path and related logic/tests.

For now, this keeps the `concurrentUpdatesByDefaultOverride` argument in
`createContainer` and `createHydrationContainer` and ignores the value
to prevent more breaking changes to `react-reconciler` in the RC stage.

DiffTrain build for [14a4699](14a4699)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants